Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to Get IKE Security Associations on Virtual Network Gateway Connections #13853

Merged
merged 39 commits into from
Jan 14, 2021

Conversation

abhi7860
Copy link
Member

@abhi7860 abhi7860 commented Dec 28, 2020

Description

Customers can now fetch IKE Security Associations for their Virtual Network Gateway Connections

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@abhi7860 abhi7860 marked this pull request as ready for review December 30, 2020 09:35
@abhi7860 abhi7860 assigned abhi7860 and isra-fel and unassigned isra-fel and abhi7860 Dec 31, 2020
@abhi7860 abhi7860 requested a review from isra-fel December 31, 2020 08:13
@abhi7860 abhi7860 assigned abhi7860 and unassigned abhi7860 Dec 31, 2020
Abhishek Shah added 2 commits December 31, 2020 01:05
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things missing in your PR:

  • You are using some new API IVirtualNetworkGatewayConnectionsOperations.GetIkeSas() that is available in the SDK on network-august branch right now. Please check in your local SDKs (and any related changes) to unblock build
  • You need tests to cover the new command

src/Network/Network/ChangeLog.md Outdated Show resolved Hide resolved
@isra-fel isra-fel added this to the S181 (2021-01-19) milestone Jan 12, 2021
@isra-fel
Copy link
Member

Hi @abhi7860 as @MikhailTryakhov 's PR #13927 already merged network-august branch to master, network-august branch became stale. Any later PR (including this one) merged into network-august won't be included in this release.
Please edit the base branch of your PR to release-2021-01-19 if you wish to catch this release

abhi7860 and others added 3 commits January 12, 2021 09:53
Co-authored-by: Yeming Liu <felix_liu@outlook.com>
Co-authored-by: Yeming Liu <felix_liu@outlook.com>
This reverts commit d865935.
@abhi7860 abhi7860 changed the base branch from network-august to release-2021-01-19 January 12, 2021 18:43
@abhi7860 abhi7860 requested a review from isra-fel January 13, 2021 17:59
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isra-fel isra-fel merged commit 6389904 into Azure:release-2021-01-19 Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants