-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to Get IKE Security Associations on Virtual Network Gateway Connections #13853
Conversation
This reverts commit 34f42e1.
This reverts commit 84a1add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things missing in your PR:
- You are using some new API
IVirtualNetworkGatewayConnectionsOperations.GetIkeSas()
that is available in the SDK onnetwork-august
branch right now. Please check in your local SDKs (and any related changes) to unblock build - You need tests to cover the new command
This reverts commit 1ddcb32.
src/Network/Network.Test/ScenarioTests/VirtualNetworkGatewayConnectionTests.ps1
Outdated
Show resolved
Hide resolved
src/Network/Network.Test/ScenarioTests/VirtualNetworkGatewayConnectionTests.ps1
Outdated
Show resolved
Hide resolved
Hi @abhi7860 as @MikhailTryakhov 's PR #13927 already merged |
Co-authored-by: Yeming Liu <felix_liu@outlook.com>
Co-authored-by: Yeming Liu <felix_liu@outlook.com>
This reverts commit d865935.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Customers can now fetch IKE Security Associations for their Virtual Network Gateway Connections
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be addeda cmdlet design review was approved for the changes in this repository (Microsoft internal only)
the markdown help files have been regenerated using the commands listed here