Skip to content

Set-AzureApiManagementHostnames fix + new SDK version #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Conversation

ailn
Copy link
Contributor

@ailn ailn commented Oct 26, 2015

  • fixed bug in Set-AzureApiManagementHostnames cmdlet
  • updated SDK version
  • recorded new tests

@azurecla
Copy link

Hi @ailn, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (ailn). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@hovsepm
Copy link
Contributor

hovsepm commented Oct 28, 2015

@markcowl
Copy link
Member

@markcowl
Copy link
Member

@alin please pull the latest from the dev branch to allow the on-demand run to pass

@hovsepm
Copy link
Contributor

hovsepm commented Oct 29, 2015

@hovsepm
Copy link
Contributor

hovsepm commented Oct 29, 2015

@alin your merge did not pull anything. the SQL tests that are failing in your PR are fixed in https://github.com/Azure/azure-powershell dev branch. Please make sure you pulled from that branch (check that your upstream points to that one and not to your fork). Then update your PR with merge and rerun the on-demand job.

@markcowl
Copy link
Member

@ailn there are merge conflicts, please update

@ailn
Copy link
Contributor Author

ailn commented Oct 30, 2015

@hovsepm Sorry, merged with the wrong branch...

Conflicts:
	src/ResourceManager/ApiManagement/Commands.ApiManagement.Test/packages.config
	src/ResourceManager/ApiManagement/Commands.SMAPI.Test/packages.config
@markcowl
Copy link
Member

@ailn we just created the rlease branch, please retarget this PR at this branch if you want it in for this release

@markcowl
Copy link
Member

markcowl commented Nov 2, 2015

@ailn If you want this PR to go into this release, you need to open it against the dev branch. Otheriwse, we will look at merging it after the release next week.

@ailn
Copy link
Contributor Author

ailn commented Nov 2, 2015

@markcowl Did you mean to open against 'release' branch?

@ailn
Copy link
Contributor Author

ailn commented Nov 2, 2015

Opened new PR against release-1.0.0: #1226

@markcowl
Copy link
Member

markcowl commented Nov 3, 2015

@ailn closing as the PR targeted at the release branch is merged

@markcowl markcowl closed this Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants