Skip to content

[DO NOT MERGE]: Building Azure PowerShell MSI from PowerShellGet packages #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

ogail
Copy link
Contributor

@ogail ogail commented Oct 26, 2015

No description provided.

</Target>

<!-- Build all flavors of the installers -->
<Target Name="BuildInstaller" DependsOnTargets="RestoreNugetPackages;BuildMsBuildTask">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BuildMsBuildTask task is not required here...

ogail added 2 commits October 26, 2015 17:07
- Change output structure to flat one
- Add ability to specify source repo
- Assured PSGetModuleInfo.xml is being deleted.
- Updated Installer to append PowerShell module only to PSModulePath
@markcowl
Copy link
Member

We will need to continue to enable building from source, at least from a Jenkins job.as we discussed, enable build the msi from source.

Also, should move default 'test' target to the Test Gallery instead of the internal gallery


try
{
Remove-Item -Recurse -Force $AzurePSPath -ErrorAction SilentlyContinue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why SilentlyContinue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cuz in case path does not exist dont show error

$BuildConfig = "Release",
[Parameter(Position = 1, Mandatory = $false)]
[string]
$RepositoryLocation = "http://psget/PSGallery/api/v2/")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to be Public PSGallery url

@markcowl markcowl changed the title Building Azure PowerShell MSI from PowerShellGet packages [DO NOT MERGE]: Building Azure PowerShell MSI from PowerShellGet packages Oct 27, 2015
@markcowl
Copy link
Member

I just marked this as do not merge, since we are getting to code complete tomorrow. We can merge this after we have completed the installers for this release.

@ogail
Copy link
Contributor Author

ogail commented Oct 27, 2015

@markcowl you got it!

@ogail
Copy link
Contributor Author

ogail commented Oct 28, 2015

Jenkins project: http://azuresdkci.cloudapp.net/job/powershell-msi-new/
Successful build job from public PSGallery: http://azuresdkci.cloudapp.net/job/powershell-msi-new/2/
Successful build job from source: http://azuresdkci.cloudapp.net/job/powershell-msi-new/3/

ogail added 2 commits October 29, 2015 11:39
* 'dev' of github.com:Azure/azure-powershell: (87 commits)
  update help file
  Remove pass thru from RemoveDeployment
  address review feedback
  update test records
  [#106772718] Search for subscription in all tenants when no tenantId is specified in Get-AzureRmSubscription and Set-AzureRmContext cmdlets
  remove all local feed packages
  Update help file
  Remove tabs from ps1 files
  Data masking test records fix
  updated hdi sdk version and fixed build failures
  RoleDefinition PUT and DELETE requests should use first assignable scope as the url scope
  fixed indentation in ps1.
  Fixed minor issue.
  Fix bad merge
  Added selection of first subscription (if there are any) if Set-AzureRmContext was called with only tenantId
  Add excluded provisiong state to make cancel deployment work
  Remove provisioning state from getdeployment
  Remove passthru from unit tests
  Authorization: Add paging for role assignment list/get calls
  Remove additional warning messages
  ...

# Conflicts:
#	setup/azurecmdfiles.wxi
#	src/ResourceManager/Profile/Commands.Profile/Microsoft.Azure.Commands.Profile.dll-Help.psd1
@ogail
Copy link
Contributor Author

ogail commented Nov 9, 2015

@markcowl wanted to check if this will be merged soon

@markcowl
Copy link
Member

Closing for now. We will revive this in the installer reqrite

@markcowl markcowl closed this Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants