-
Notifications
You must be signed in to change notification settings - Fork 4k
Support automatic RP registration #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -39,6 +40,14 @@ static AzureRMCmdlet() | |||
AzureSession.DataStore = new DiskDataStore(); | |||
} | |||
|
|||
public AzureRMCmdlet() | |||
{ | |||
AzureSession.ClientFactory.RemoveHandler(typeof(RPRegistrationDelegatingHandler)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jianghaolu this can be improved when we change the AddHandler to override existing handler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it as it would assure that the handler is refreshed.
@ogail new authentication package is published |
on demand job is here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/222/ |
{ | ||
if (retryCount++ > RetryCount) | ||
{ | ||
throw new TimeoutException(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add in a message here so the timeout shows up in the exception-catching trace below (or add a specific trace for the timeout)
@ogail the two recommended fixes are minimal, so the on-demand doesn't need to be re-run if you fix these. |
on demand job is here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/224/ |
Support automatic RP registration
No description provided.