Make storage data cmdlets work with ARM and ASM #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing in storage cmdlets Add GetCurrentStorageAccount implementation for ARM. Add comments to new public utility methods.
…isplay in profile cmdlets, and implementing set current storage account for ARM
…ubscription storage accounts for non-default subscriptions; fixing merge issue with selecting profile
| @@ -27,7 +28,7 @@ public class GetAzureRMContextCommand : AzureRMCmdlet | |||
| { | |||
| protected override void ProcessRecord() | |||
| { | |||
| WriteObject((PSAzureContext)AzureRMCmdlet.DefaultProfile.Context); | |||
| WriteObject((PSAzureContext)AzureRmProfileProvider.Instance.Profile.Context); | |||
There was a problem hiding this comment.
Nit: this can now be simplified to just this.DefaultProfile.Context
|
LGTM |
| @@ -0,0 +1,16 @@ | |||
| using System; | |||
| return new CloudStorageAccount( | ||
| new StorageCredentials(accountName, | ||
| Convert.ToBase64String(Encoding.UTF8.GetBytes(Guid.NewGuid().ToString()))), | ||
| new Uri(string.Format("https://{0}.blob.core.windows.net", accountName)), |
|
on demand run here: http://azuresdkci.cloudapp.net/job/powershell-on-demand/214/ (and passing) |
markcowl
added a commit
that referenced
this pull request
Oct 5, 2015
Make storage data cmdlets work with ARM and ASM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.