Fix target hyperv generation for vmware & msi auth check (#26211)

Co-authored-by: Sam Lee <samlee3@microsoft.com>
Azure · Oct 21, 2024 · 5d33563 · 5d33563
1 parent 1102f79
commit 5d33563
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/Migrate/Migrate.Autorest/custom/Initialize-AzMigrateHCIReplicationInfrastructure.ps1 b/src/Migrate/Migrate.Autorest/custom/Initialize-AzMigrateHCIReplicationInfrastructure.ps1
@@ -161,7 +161,13 @@ function Initialize-AzMigrateHCIReplicationInfrastructure {
         }
 
         if (-not $userObject) {
-            $userObject = Get-AzADServicePrincipal -ApplicationID $context.Account.Id
+            if ($context.Account.Id.StartsWith("MSI@")) {
+                $hostname = $env:COMPUTERNAME
+                $userObject = Get-AzADServicePrincipal -DisplayName $hostname
+            }
+            else {
+                $userObject = Get-AzADServicePrincipal -ApplicationID $context.Account.Id
+            }
         }
 
         if (-not $userObject) {

diff --git a/src/Migrate/Migrate.Autorest/custom/New-AzMigrateHCIServerReplication.ps1 b/src/Migrate/Migrate.Autorest/custom/New-AzMigrateHCIServerReplication.ps1
@@ -386,6 +386,14 @@ function New-AzMigrateHCIServerReplication {
         $customProperties.TargetCpuCore = if ($HasTargetVMCPUCore) { $TargetVMCPUCore } else { $machine.NumberOfProcessorCore }
         $customProperties.IsDynamicRam = if ($HasIsDynamicMemoryEnabled) { $isDynamicRamEnabled } else {  $isSourceDynamicMemoryEnabled }
 
+        # Determine target VM Hyper-V Generation
+        if ($SiteType -eq $SiteTypes.HyperVSites) { # Hyper-V
+            $customProperties.HyperVGeneration = $machine.Generation
+        }
+        else { # VMware
+            $customProperties.HyperVGeneration = if ($machine.Firmware -eq "BIOS") { "1" } else { "2" }
+        }
+
         # Validate TargetVMRam
         if ($HasTargetVMRam) {
             # TargetVMRam needs to be greater than 0