Complete versioned policy support + fixes (#25181)

* Handful of cleanup items (no recording files) - Fix default formatting for output objects - Remove leftover auto-generated InputObject parameters - Remove Helpers.psm1, which was replaced by Helpers.ps1 - Add info to error message in test harness * Implement -Version and -ListVersion parameters on Get-AzPolicy[Set]Definition Add tests for -Version and -ListVersion * Add recordings for all non-backcompat tests * Add rest of recording files (backcompat) * Tag tests that create big recording files with LiveOnly to get under the Github PR maximum size * Rerecord all tests * Add back InputObject parameters to Remove-* cmdlets. * Complete support for getting and assigning versioned policy definitions and sets Fix for GH issue: #25084 Fix for GH issue: #24971 Fix for "Get-AzPolicyExemption requests unnecessary parameter for Get-AzPolicyExemption in v12" * Re-record tests
Azure · Jun 17, 2024 · 1d05cfa · 1d05cfa
1 parent d9b8414
commit 1d05cfa
Show file tree

Hide file tree

Showing 92 changed files with 12,178 additions and 7,834 deletions.
diff --git a/src/Resources/Policy.Autorest/README.md b/src/Resources/Policy.Autorest/README.md
@@ -28,7 +28,7 @@ For information on how to develop for `Az.Policy`, see [how-to.md](how-to.md).
 
 ``` yaml
 # Please specify the commit id that includes your features to make sure generated codes stable.
-commit: 33da947dfea91e16a4e62c663a13de4f0fa72251
+commit: 412364b282e52b50eadc3cd88d56d283b6c8712a
 require:
 # readme.azure.noprofile.md is the common configuration file
   - $(this-folder)/../../readme.azure.noprofile.md

diff --git a/src/Resources/Policy.Autorest/custom/Get-AzPolicyAssignment.ps1 b/src/Resources/Policy.Autorest/custom/Get-AzPolicyAssignment.ps1
@@ -214,14 +214,11 @@ process {
                     $calledParameters.ResourceGroupName = $resolved.ResourceGroupName
                 }
                 'resource' {
-                    $resourceId = $resolved.Scope
-                    $parts = ($resourceId -split '/')
-                    $first = 1
-                    $last = $parts.Length - 2
                     $calledParameterSet = 'List1'
-                    $calledParameters.ResourceProviderNamespace = $parts[0]
-                    $calledParameters.ResourceName = $parts[$parts.Length-1]
-                    $calledParameters.ResourceType = [System.String]::Join('/', $parts[$first..$last])
+                    $calledParameters.ResourceProviderNamespace = $resolved.ResourceNamespace
+                    $calledParameters.ResourceName = $resolved.ResourceName
+                    $calledParameters.ResourceType = $resolved.ResourceType
+                    $calledParameters.ParentResourcePath = '.'
                     $calledParameters.SubscriptionId = @($resolved.SubscriptionId)
                     $calledParameters.ResourceGroupName = $resolved.ResourceGroupName
                 }

diff --git a/src/Resources/Policy.Autorest/custom/Get-AzPolicyDefinition.ps1 b/src/Resources/Policy.Autorest/custom/Get-AzPolicyDefinition.ps1
@@ -376,6 +376,7 @@ process {
         $item | Add-Member -MemberType NoteProperty -Name 'Metadata' -Value (ConvertObjectToPSObject $item.Metadata) -Force
         $item | Add-Member -MemberType NoteProperty -Name 'Parameter' -Value (ConvertObjectToPSObject $item.Parameter) -Force
         $item | Add-Member -MemberType NoteProperty -Name 'PolicyRule' -Value (ConvertObjectToPSObject $item.PolicyRule) -Force
+        $item | Add-Member -MemberType NoteProperty -Name 'Versions' -Value ([array]($item.Versions)) -Force
         $PSCmdlet.WriteObject($item)
     }
 }

diff --git a/src/Resources/Policy.Autorest/custom/Get-AzPolicyExemption.ps1 b/src/Resources/Policy.Autorest/custom/Get-AzPolicyExemption.ps1
@@ -217,14 +217,11 @@ process {
                     $calledParameters.ResourceGroupName = $resolved.ResourceGroupName
                 }
                 'resource' {
-                    $resourceId = $resolved.Scope
-                    $parts = ($resourceId -split '/')
-                    $first = 1
-                    $last = $parts.Length - 2
                     $calledParameterSet = 'List2'
-                    $calledParameters.ResourceProviderNamespace = $parts[0]
-                    $calledParameters.ResourceName = $parts[$parts.Length-1]
-                    $calledParameters.ResourceType = [System.String]::Join('/', $parts[$first..$last])
+                    $calledParameters.ResourceProviderNamespace = $resolved.ResourceNamespace
+                    $calledParameters.ResourceName = $resolved.ResourceName
+                    $calledParameters.ResourceType = $resolved.ResourceType
+                    $calledParameters.ParentResourcePath = '.'
                     $calledParameters.SubscriptionId = @($resolved.SubscriptionId)
                     $calledParameters.ResourceGroupName = $resolved.ResourceGroupName
                 }

diff --git a/src/Resources/Policy.Autorest/custom/Get-AzPolicySetDefinition.ps1 b/src/Resources/Policy.Autorest/custom/Get-AzPolicySetDefinition.ps1
@@ -367,6 +367,7 @@ process {
         $item | Add-Member -MemberType NoteProperty -Name 'Parameter' -Value (ConvertObjectToPSObject $item.Parameter) -Force
         $item | Add-Member -MemberType NoteProperty -Name 'PolicyDefinitionGroup' -Value (ConvertObjectToPSObject $item.PolicyDefinitionGroup) -Force
         $item | Add-Member -MemberType NoteProperty -Name 'PolicyDefinition' -Value (ConvertObjectToPSObject $item.PolicyDefinition) -Force
+        $item | Add-Member -MemberType NoteProperty -Name 'Versions' -Value ([array]($item.Versions)) -Force
         $PSCmdlet.WriteObject($item)
     }
 }