Add ResourceNameCompleter

[maddieclayton]

No description provided.

[markcowl]

why just the first element?

[maddieclayton]

resolved offline - this is the ResourceGroupName

[markcowl]

You can use parentResources.Any(s => !string.IsNullOrWhitespace(s))

[maddieclayton]

resolved offline - this is the ResourceGroupName

[markcowl]

Use one of the overloads that allows you to cancel the wait if it takes too long

[maddieclayton]

Done - this will only ever be used in the tests, and we never want to spend more than 5 minutes on this test.

[markcowl]

The nested if statements make this difficult to read. We should separate the code for making the client call from the code for filtering the response. This will also enable us to mock out the client response and test our filtering logic. Also, we should use System,Linq to filter responses rather than for loops and if statements.

[maddieclayton]

Done

[MiYanni]

Recommendation (declaration and initialization in the same statement):

var allProviders = string.IsNullOrWhiteSpace(resourceGroupName)
    ? client.Resources.ListAsync(odataQuery)
    : client.ResourceGroups.ListResourcesAsync(resourceGroupName, odataQuery);

[maddieclayton]

done.

[MiYanni]

This block can simply be (removes code duplication and verbosity):
Note: ForEach + data transformation = Select in LINQ

var timeoutDuration = _timeout == -1 ? TimeSpan.FromMinutes(5) : TimeSpan.FromSeconds(_timeout);
var hasNotTimedOut = allProviders.Wait(timeoutDuration);
var hasResult = allProviders.Result != null;
var isSuccessful = hasNotTimedOut && hasResult;

#if DEBUG
if (!isSuccessful)
{
    throw new InvalidOperationException(!hasResult ? "Result from client.Providers is null" : Resources.TimeOutForProviderList);
}
#endif

return isSuccessful
    ? allProviders.Result.Select(resource => new ResourceIdentifier(resource.Id)).ToList()
    : new List<ResourceIdentifier>();

[maddieclayton]

done.

[MiYanni]

Entire method could be (reduces tab depth and short-circuits on excluded resources):

return ids.Where(resource => {
    if(resource.ParentResource == null)
    {
        return true;
    }

    var actualParentResources = resource.ParentResource.Split('/').Where((pr, i) => i % 2 != 0).ToArray();
    var parentResourcesExceptFirst = parentResources.Skip(1).ToArray();
    if(actualParentResources.Count() != parentResourcesExceptFirst.Count())
    {
#if DEBUG
        throw new InvalidOperationException("Improper number of parent resources were given");
#endif
        return true;
    }

    return !actualParentResources.Any((pr, i) => 
        !string.IsNullOrEmpty(parentResourcesExceptFirst[i]) && 
        !string.Equals(pr, parentResources[i], StringComparison.OrdinalIgnoreCase));
}.Select(resource => resource.ResourceName).ToList()

[maddieclayton]

done.

Comments have been addressed.