Skip to content

Conversation

@vidai-msft
Copy link
Contributor

This pull request includes several changes aimed at improving the handling and representation of detected properties in the sanitizer telemetry. The most important changes include the introduction of a new DetectedPropertiesInfo class, updates to the SanitizerTelemetry class to use this new class, and modifications to methods that interact with detected properties.

Improvements to Detected Properties Handling:

  • New DetectedPropertiesInfo Class:

  • Updates to SanitizerTelemetry Class:

Method Modifications:

  • WriteSecretsWarningMessage Method:

    • Updated the condition to check if detected properties are empty using the new IsEmpty property of DetectedPropertiesInfo. Adjusted the warning message to use PropertyNames from DetectedPropertiesInfo. (src/Common/AzurePSCmdlet.cs, src/Common/AzurePSCmdlet.csL436-R442)
  • PopulateSanitizerPropertiesFromQos Method:

    • Refactored to build a detailed string representation of detected properties using the new DetectedPropertiesInfo class. (src/Common/MetricHelper.cs, src/Common/MetricHelper.csL484-R505)

@vidai-msft
Copy link
Contributor Author

/azp run azure-powershell-common - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vidai-msft vidai-msft merged commit ae44bad into main Oct 20, 2024
2 checks passed
@vidai-msft vidai-msft deleted the vidai/secrets-detection-telemetry branch October 20, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants