Skip to content

Conversation

BethanyZhou
Copy link
Contributor

@BethanyZhou BethanyZhou commented May 30, 2024

  • Added a class named ConfigInfo to model the needed info in our metrics to track the values of Az Configs specifically
    • ExtendedProperties provides extendibility for further usage
  • Will record the config value of LoginExperienceV2 when user executes Connect-AzAccount each time. We can calculate the percentage of turning off new login experience and observe the trend in a certain period.
    image

NoriZC
NoriZC previously approved these changes May 30, 2024
@isra-fel
Copy link
Member

The description said "add ConfigInfo as a dictionary" but the screenshot shown a string property named "LoginExperienceV2". Which one is correct?

@BethanyZhou
Copy link
Contributor Author

Hi @isra-fel, thanks for asking.

ConfigInfo is a dictionary, { "LoginExperienceV2" = "On"} is one of key-value pair inside it. For instance, if we decide to track the value of EnableLoginByWam, its value will be { "LoginExperienceV2" = "On"; EnableLoginByWam = "true"}. Eventually, all key-value pairs in ConfigInfo will be taken one by one and included into properties.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name ConfigInfo is too general - others may mix it up with ConfigDefinition. Consider ConfigMatrics or ConfigTelemetry etc

@BethanyZhou BethanyZhou requested a review from isra-fel June 14, 2024 05:11
@NoriZC NoriZC merged commit f44d051 into main Jun 14, 2024
@NoriZC NoriZC deleted the bez/addTelemetry branch June 14, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants