Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Microsoft.ApplicationInsights from 2.4.0 to 2.12.0 #276

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Upgrade Microsoft.ApplicationInsights from 2.4.0 to 2.12.0 #276

merged 1 commit into from
Jul 6, 2021

Conversation

msJinLei
Copy link
Contributor

@msJinLei msJinLei commented Jul 5, 2021

  • Upgrade Microsoft.ApplicationInsights from 2.4.0 to 2.12.0

isra-fel
isra-fel requested changes Jul 5, 2021
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested it out with powershell modules?
Jin Lei has tested locally and judged from the traces the telemetry data was sent to Azure

src/Common/MetricHelper.cs Show resolved Hide resolved
src/Common/MetricHelper.cs Show resolved Hide resolved
@isra-fel isra-fel assigned dingmeng-xue and unassigned msJinLei Jul 5, 2021
@dingmeng-xue dingmeng-xue merged commit b117855 into main Jul 6, 2021
@isra-fel isra-fel deleted the applicationinsighnts branch July 7, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

Assignees

@dingmeng-xue dingmeng-xue

Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msJinLei @isra-fel @dingmeng-xue