Adding support for FIPS 140-3 #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norakoiralamsft
requested review from
D1v38om83r,
nkuchta and
a team
as code owners
malhotrarohit
previously approved these changes
Jan 8, 2025
jscalev
reviewed
Jan 9, 2025
| @@ -263,6 +263,21 @@ def __init__(self, config): | |||
| self.sudoers_dir_base = '/usr/local/etc' | |||
| self.distro_name = 'Ubuntu' | |||
|
|
|||
| def restart_ssh_service(self): | |||
There was a problem hiding this comment.
Was this added by mistake? I don't see where it is called.
There was a problem hiding this comment.
No, it was added on purpose, on newer Ubuntu distros, while the operation succeeds, the password doesn't reset. Function is being called here: https://github.com/Azure/azure-linux-extensions/blob/adb7396fb0479db542973917edb6fc709de9851c/VMAccess/vmaccess.py#L173C1-L174C1
malhotrarohit
approved these changes
Jan 10, 2025
narrieta
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openssl cms command is needed to support FIPS 140-3, keeping smime command as a backup
Doc: Support for FIPS 140-3 in VM Agents and Extensions