Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stalling on PagedCollection, when value is empty but nextLink is valid #999

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

weidongxu-microsoft
Copy link
Member

Fix #996

@weidongxu-microsoft weidongxu-microsoft changed the title fix stalling when values is empty but nextLink is valid fix stalling on PagedCollection, when values is empty but nextLink is valid Mar 6, 2020
@weidongxu-microsoft weidongxu-microsoft changed the title fix stalling on PagedCollection, when values is empty but nextLink is valid fix stalling on PagedCollection, when value is empty but nextLink is valid Mar 6, 2020
@yaohaizh
Copy link

yaohaizh commented Mar 6, 2020

@weidongxu-microsoft I'm okay with this change. But my second taking is that whether the KeyVault team breaks the protocol of the swagger spec for nextLinkPage because empty for next link is definitely not a good practice.

https://github.com/Azure/autorest/blob/master/docs/extensions/readme.md#x-ms-pageable

//cc @yungezz

@weidongxu-microsoft
Copy link
Member Author

@yaohaizh

Keyvault actually have an empty value, with valid nextLink. I.e., they seems got one page which is empty, and still need to continue the paging.

My guess is they are doing some filtering internally on the page result before returning to us.

@jasonxdhu

Would you please share more on this case?

@yungezz
Copy link
Member

yungezz commented Mar 6, 2020

agree with @yaohaizh , other sdks should meet similar issue: nextLInk valid while empty page content. Can we have a look at Keyvault swagger and file issue there if indeed a swagger issue?

@weidongxu-microsoft weidongxu-microsoft merged commit 53fd15e into master Mar 17, 2020
@weidongxu-microsoft weidongxu-microsoft deleted the fix_pagedcollection branch March 17, 2020 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Dead loop occurs when NextPageLink is not null but resource results are empty
4 participants