Cosmos DB: update to 2019 12 and add interface #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenTanyi
requested review from
weidongxu-microsoft,
xseeseesee and
yaohaizh
as code owners
yaohaizh
approved these changes
Mar 5, 2020
xseeseesee
approved these changes
Mar 5, 2020
weidongxu-microsoft
approved these changes
Mar 5, 2020
| location.FailoverPriority = i; | ||
| location.LocationName = policyInner.LocationName; | ||
| locations.Add(location); | ||
| failoverPolicies[i].FailoverPriority = i; |
There was a problem hiding this comment.
Just ask, priority=0 is highest or lowest?
There was a problem hiding this comment.
The 0 seems highest. Priority always from 0 ~ n - 1 in order from response.
src/ResourceManagement/CosmosDB/Domain/CosmosDBAccount/Definition/IDefinition.cs
Show resolved
Hide resolved
| /// Specifies a composite index empty list to set every composite path. | ||
| /// </summary> | ||
| /// <returns>The next stage of the definition.</returns> | ||
| IWithCompositeIndexList<ParentT> WithCompositeIndexEmptyList(); |
There was a problem hiding this comment.
Not sure, DefineCompositeIndex or WithNewCompositeIndexList?
There was a problem hiding this comment.
I'm not sure about it, too. I think using define for a list inside same interface is a little strange.
There was a problem hiding this comment.
I use the WithNewCompositeIndexList
src/ResourceManagement/CosmosDB/Domain/CosmosDBAccount/Definition/IDefinition.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #991