-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmos DB: update to 2019 12 and add interface #994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
location.FailoverPriority = i; | ||
location.LocationName = policyInner.LocationName; | ||
locations.Add(location); | ||
failoverPolicies[i].FailoverPriority = i; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just ask, priority=0 is highest or lowest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 0 seems highest. Priority always from 0 ~ n - 1 in order from response.
src/ResourceManagement/CosmosDB/Domain/CosmosDBAccount/Definition/IDefinition.cs
Show resolved
Hide resolved
/// Specifies a composite index empty list to set every composite path. | ||
/// </summary> | ||
/// <returns>The next stage of the definition.</returns> | ||
IWithCompositeIndexList<ParentT> WithCompositeIndexEmptyList(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, DefineCompositeIndex
or WithNewCompositeIndexList
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about it, too. I think using define
for a list inside same interface is a little strange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use the WithNewCompositeIndexList
close #991