Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources: support api version when listing generic resources #1015

Merged
merged 3 commits into from
Mar 19, 2020

Conversation

xseeseesee
Copy link
Contributor

fix #978

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. Though it might be a bit concern that we do an extra request only for some user case that need the apiVersion (maybe more cases will not need it).

@xseeseesee
Copy link
Contributor Author

Looks OK. Though it might be a bit concern that we do an extra request only for some user case that need the apiVersion (maybe more cases will not need it).

For users who want to do some update operation, it's not extra request as they will need apiVersion. For others, they can avoid the extra request by not using resource.apiVersion().

@weidongxu-microsoft
Copy link
Member

Nice. It is lazy evaluation. So no cost if no use.

@xseeseesee xseeseesee closed this Mar 19, 2020
@xseeseesee xseeseesee reopened this Mar 19, 2020
@xseeseesee
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xseeseesee xseeseesee merged commit a1771c0 into master Mar 19, 2020
@xseeseesee xseeseesee deleted the fix-generic-resources branch March 19, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] IGenericResource.ApiVersion is always null
2 participants