Update serde-xml-rs requirement from 0.7.0 to 0.8.0 #195
Conversation
dependabot
bot
added
dependencies
|
CI fails during unit tests. |
dependabot
bot
force-pushed
the
dependabot/cargo/serde-xml-rs-0.8.0
branch
from
6f5e254 to
540da76
Compare
Updates the requirements on [serde-xml-rs](https://github.com/RReverser/serde-xml-rs) to permit the latest version. - [Release notes](https://github.com/RReverser/serde-xml-rs/releases) - [Commits](RReverser/serde-xml-rs@0.7.0...0.8.0) --- updated-dependencies: - dependency-name: serde-xml-rs dependency-version: 0.8.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/cargo/serde-xml-rs-0.8.0
branch
from
540da76 to
10cf07e
Compare
Starting from serde-xml-rs 0.8.0, namespace support was added for deserialization of xml tags. So it is necessary to explicitly add tags `wa:` into each struct, when actual XML data is tagged with namespace. See also RReverser/serde-xml-rs#228, RReverser/serde-xml-rs#50.
|
Fixed the unit tests. Starting from serde-xml-rs 0.8.0, namespace support was added for deserialization of xml tags. So it is necessary to explicitly add tags See also RReverser/serde-xml-rs#228, RReverser/serde-xml-rs#50. |
There was a problem hiding this comment.
This looks good to me, I think.
I'm not familiar with XML namespace details, so I brushed up a little bit here. They seem a little weird in that the prefix appears to be a convenient way to reference the URI, but just the prefix shows up in the deserialized field names sans URI, but that does appear to be how this works, and matches what cloud-init documents in its example.
| /// <ProvisioningSection> | ||
| /// <Version>1.0</Version> | ||
| /// <Environment xmlns="http://schemas.dmtf.org/ovf/environment/1" | ||
| /// xmlns:wa="http://schemas.microsoft.com/windowsazure"> |
There was a problem hiding this comment.
It wouldn't be XML if the schema URL wasn't a 404
There was a problem hiding this comment.
I am also not an expert of XML namespace, so I am not sure if the changes for unit tests are enough for the new serde-xml-rs version. If you have a better idea, feel free to create a PR. ;-)
Updates the requirements on serde-xml-rs to permit the latest version.
Release notes
Sourced from serde-xml-rs's releases.
Commits
525a952💥 Namespaces and other niceties (#228)c0f2c07🔖 Version 0.7.15eb0e42Defer document declaration generation to xml-rs crate (#231)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)