Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating sshd config for PasswordAuthentication #136

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Updating sshd config for PasswordAuthentication #136

merged 1 commit into from
Nov 12, 2024

Conversation

balakreddy
Copy link
Contributor

Update /etc/ssh/sshd_config for PasswordAuthentication to yes and restart sshd. Fixes #67

How to use

Testing done

dongsupark
dongsupark reviewed Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the PR.

libazureinit/src/provision/password.rs Show resolved Hide resolved
libazureinit/src/provision/ssh.rs Outdated Show resolved Hide resolved
jeremycline
jeremycline requested changes Oct 23, 2024
View reviewed changes
libazureinit/src/provision/ssh.rs Outdated Show resolved Hide resolved
libazureinit/src/provision/ssh.rs Outdated Show resolved Hide resolved
libazureinit/src/provision/ssh.rs Outdated Show resolved Hide resolved
libazureinit/src/provision/ssh.rs Outdated Show resolved Hide resolved
dongsupark
dongsupark reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the error type issue seems now resolved.

libazureinit/src/provision/ssh.rs Outdated Show resolved Hide resolved
libazureinit/src/provision/ssh.rs Outdated Show resolved Hide resolved
libazureinit/src/provision/ssh.rs Outdated Show resolved Hide resolved
@dongsupark
Copy link
Collaborator

Thanks, looks good to me.
Can you please rebase?

@balakreddy
Updating sshd config for PasswordAuthentication
a3cc18f 
Update /etc/ssh/sshd_config for PasswordAuthentication
to yes and restart sshd. Fixes Azure#67

Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
@balakreddy balakreddy requested a review from dongsupark November 6, 2024 21:51
@dongsupark
Copy link
Collaborator

Still needs an approval from @jeremycline

anhvoms
anhvoms approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@anhvoms anhvoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

jeremycline
jeremycline approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@jeremycline jeremycline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@dongsupark dongsupark merged commit 0267ea8 into Azure:main Nov 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhvoms anhvoms anhvoms approved these changes

@dongsupark dongsupark dongsupark approved these changes

@jeremycline jeremycline jeremycline approved these changes

@cjp256 cjp256 Awaiting requested review from cjp256

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libazureinit needs to update the sshd config when it provisions a user with password
5 participants
@balakreddy @dongsupark @jeremycline @cjp256 @anhvoms