Updating package version ranges to be inclusive #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soninaren
reviewed
Oct 31, 2018
| <PackageReference Include="Microsoft.Azure.WebJobs" Version="[2.2.0,2.3.0)" /> | ||
| <PackageReference Include="Microsoft.Azure.WebJobs.Extensions" Version="[2.2.0,2.3.0)" /> | ||
| <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Http" Version="[1.1.0,1.2.0)" /> | ||
| <PackageReference Include="Microsoft.Azure.WebJobs" Version="[2.2.0,2.4.0)" /> |
There was a problem hiding this comment.
Do we want to move the min version to 2.3.0? This will still use 2.2.0 unless user explicitly updates it.
There was a problem hiding this comment.
I'd be fine with that, but it means that we'd have to first release all the packages, before releasing this package and updating our tools to use this. @fabiocav ? How do you usually manage these release dependencies?
There was a problem hiding this comment.
I'll leave the range wider at this point - won't cause any problems.
There was a problem hiding this comment.
As long as the redirects are good, this won't be an issue. The only issue here would be if customers update the package reference without having the latest CLI.
soninaren
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing to release 2.3.0 packages, but the current 1.0.23 version of the tools isn't inclusive of this version, causing package installation to fail.