Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch .NET isolated DF templates #1513

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Patch .NET isolated DF templates #1513

merged 1 commit into from
Mar 29, 2024

Conversation

davidmrdavid
Copy link
Contributor

We've received recent reports that the DF templates for .NET isolated have stopped working out of the box. This PR makes 3 fixes to address the feedback:

  1. Updates the DF isolated extension to version 1.1.1 (can I use a * pattern to have it always download the latest?)

  2. Updates the Http extension to version 3.1.0 (was getting the following warning otherwise)

"""
Warning As Error: Detected package downgrade: Microsoft.Azure.Functions.Worker.Extensions.Http from 3.1.0 to 3.0.13. Reference the package directly from the project to select a different version.

FunctionApp2 -> Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore 1.2.0 -> Microsoft.Azure.Functions.Worker.Extensions.Http (>= 3.1.0)

FunctionApp2 -> Microsoft.Azure.Functions.Worker.Extensions.Http (>= 3.0.13)

"""

  1. changes the use of CreateCheckStatusResponse to CreateCheckStatusResponseAsync which should address a runtime failure reading:

"""
Exception: System.InvalidOperationException: Synchronous operations are disallowed. Call WriteAsync or set AllowSynchronousIO to true instead.
"""

@davidmrdavid
Copy link
Contributor Author

davidmrdavid commented Mar 28, 2024

I see the CI tests are failing to run, probably permissions-based. I think @soninaren has the permissions to run them?

@davidmrdavid
Copy link
Contributor Author

@fabiocav - can we get an approval for this change? I see the tests aren't passing for what seems like a permission error. Usually I'd ping Naren to get those resolved (I think he has the right permissions) but I know he's OOF. Do you know how to get the CI passing?

@fabiocav
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fabiocav
Copy link
Member

@jviau had already approved, but I just fixed a pipeline issue that was causing the build to break. Once that is green, you should be good to merge.

@fabiocav fabiocav merged commit 39602d6 into dev Mar 29, 2024
2 checks passed
@fabiocav fabiocav deleted the dajusto/update-df-isolated branch March 29, 2024 22:56
@fabiocav
Copy link
Member

Just went ahead and merged it

@javtec
Copy link

javtec commented Apr 23, 2024

I was able to finally get the sample code to work from the instructions above. However, the instructions were not complete to solve the issue. @davidmrdavid you had mentioned to simply replace "CreateCheckStatusResponse" with "CreateCheckStatusResponseAsync".
But the final fix was to replace the whole line of code from this:

"return client.CreateCheckStatusResponse(req, instanceId);"

to this:

"return await client.CreateCheckStatusResponseAsync(req, instanceId);"

I added "await" and that got the code working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants