Skip to content

Fixes #115 by using the passed CancellationToken in MemoryBufferWriter #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fixes #115 by using the passed CancellationToken in MemoryBufferWriter #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Microsoft.Azure.SignalR.Serverless.Protocols/Internal/MemoryBufferWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,10 @@ public override Task CopyToAsync(Stream destination, int bufferSize, Cancellatio
if (_completedSegments == null)
{
// There is only one segment so write without awaiting.
return destination.WriteAsync(_currentSegment, 0, _position);
return destination.WriteAsync(_currentSegment, 0, _position, cancellationToken);
}

return CopyToSlowAsync(destination);
return CopyToSlowAsync(destination, cancellationToken);
}

private void EnsureCapacity(int sizeHint)
Expand Down Expand Up @@ -184,7 +184,7 @@ private void AddSegment(int sizeHint = 0)
_position = 0;
}

private async Task CopyToSlowAsync(Stream destination)
private async Task CopyToSlowAsync(Stream destination, CancellationToken cancellationToken)
{
if (_completedSegments != null)
{
Expand All @@ -193,11 +193,11 @@ private async Task CopyToSlowAsync(Stream destination)
for (var i = 0; i < count; i++)
{
var segment = _completedSegments[i];
await destination.WriteAsync(segment.Buffer, 0, segment.Length);
await destination.WriteAsync(segment.Buffer, 0, segment.Length, cancellationToken);
}
}

await destination.WriteAsync(_currentSegment, 0, _position);
await destination.WriteAsync(_currentSegment, 0, _position, cancellationToken);
}

public byte[] ToArray()
Expand Down