Move implicit output bindings serialization logic to Python library #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2020
Hazhzeng
commented
Apr 2, 2020
| has_return = True | ||
| return_binding_name = f'{desc.type}_ret' | ||
| has_implicit_return = True | ||
| return_binding_name = desc.type |
There was a problem hiding this comment.
This is the line we refer to our trigger bindings (a.k.a. python-library activity-trigger) for serializing implicit output values.
davidmrdavid
reviewed
Apr 2, 2020
|
The same here, looks good to me. Just if we have someone from durable function have a look that will be great. |
davidmrdavid
approved these changes
Apr 22, 2020
Hazhzeng
force-pushed
the
hazeng/fix-implicit-out
branch
from
05d6356 to
01c49c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Even when a trigger type is marked with implicit output, it is still possible for an extension to marshal the output result (e.g. Python Durable Function's ActivityTrigger needs to serialize the return result into JSON when it sends to the durable extension).
Justification
Handing over this control to Python Library allows an implicit_output trigger to modify the encode behavior flexibly.