Skip to content

fix: add support for PEP 585 type hinting for 3.9+ #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

fix: add support for PEP 585 type hinting for 3.9+ #199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
53ccfab
support standard collection types in type hint for 3.9+
YunchuWang Dec 20, 2023
414cb0a
fix
YunchuWang Dec 21, 2023
87e06b8
fix
YunchuWang Dec 21, 2023
6583719
fix
YunchuWang Dec 21, 2023
1b8c295
fix
YunchuWang Dec 21, 2023
e1ba535
fix
YunchuWang Dec 21, 2023
0648666
change tests
YunchuWang Dec 21, 2023
5c02cba
fix
YunchuWang Dec 21, 2023
862f0ca
fix
YunchuWang Dec 22, 2023
45e853d
fix eh tests
YunchuWang Dec 22, 2023
94739ae
fix
YunchuWang Dec 22, 2023
e0b550c
Merge branch 'dev' into wangbill/native-type-hint
hallvictoria Aug 12, 2024
7cbabd6
Merge branch 'dev' into wangbill/native-type-hint
hallvictoria Aug 20, 2024
3095502
docs
Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@YunchuWang
YunchuWang committed Dec 21, 2023
commit 5c02cbaf6ea0cd99afb34508f9bf71755ac02641
6 changes: 3 additions & 3 deletions tests/test_eventgrid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class MyTestCase(unittest.TestCase):
def test_eventgrid_input_type(self):
check_input_type = azf_event_grid.EventGridEventInConverter.\
check_input_type_annotation

if sys.version_info >= (3, 9):
self.assertTrue(check_input_type(list[func.EventGridEvent]))

Expand All @@ -26,11 +26,11 @@ def test_eventgrid_input_type(self):
def test_eventgrid_output_type(self):
check_output_type = azf_event_grid.EventGridEventOutConverter.\
check_output_type_annotation

if sys.version_info >= (3, 9):
self.assertTrue(check_output_type(list[func.EventGridEvent]))
self.assertTrue(check_output_type(list[str]))

self.assertTrue(check_output_type(func.EventGridOutputEvent))
self.assertTrue(check_output_type(List[func.EventGridOutputEvent]))
self.assertTrue(check_output_type(str))
Expand Down
10 changes: 5 additions & 5 deletions tests/test_eventhub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ def test_eventhub_input_type(self):
azf_eh.EventHubConverter.check_input_type_annotation
)
if sys.version_info >= (3, 9):
self.assertTrue(check_input_type(list[func.EventGridEvent]))
self.assertTrue(check_input_type(list[str]))
self.assertTrue(check_input_type(list[func.EventGridEvent]))
self.assertTrue(check_input_type(list[str]))

self.assertTrue(check_input_type(func.EventHubEvent))
self.assertTrue(check_input_type(List[func.EventHubEvent]))
Expand All @@ -38,9 +38,9 @@ def test_eventhub_output_type(self):
)

if sys.version_info >= (3, 9):
self.assertTrue(check_output_type(list[func.EventGridEvent]))
self.assertTrue(check_output_type(list[str]))
self.assertTrue(check_output_type(list[func.EventGridEvent]))
self.assertTrue(check_output_type(list[str]))

self.assertTrue(check_output_type(bytes))
self.assertTrue(check_output_type(str))
self.assertTrue(check_output_type(List[str]))
Expand Down
2 changes: 1 addition & 1 deletion tests/test_kafka.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_kafka_input_type(self):
if sys.version_info >= (3, 9):
self.assertTrue(check_input_type(list[func.KafkaEvent]))
self.assertTrue(check_input_type(list[str]))

self.assertTrue(check_input_type(func.KafkaEvent))
self.assertTrue(check_input_type(List[func.KafkaEvent]))
self.assertFalse(check_input_type(str))
Expand Down