Skip to content

Add SQL Decorator for V2 model. #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 31, 2023

Conversation

lucyzhang929
Copy link
Contributor

@lucyzhang929 lucyzhang929 commented Jul 14, 2023

@lucyzhang929 lucyzhang929 marked this pull request as draft July 14, 2023 15:36
@lucyzhang929 lucyzhang929 marked this pull request as ready for review July 14, 2023 21:26
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #185 (bce5193) into dev (5fff4fc) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #185      +/-   ##
==========================================
+ Coverage   91.12%   91.27%   +0.14%     
==========================================
  Files          57       58       +1     
  Lines        3358     3415      +57     
  Branches      841      847       +6     
==========================================
+ Hits         3060     3117      +57     
  Misses        220      220              
  Partials       78       78              
Flag Coverage Δ
unittests 91.24% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
azure/functions/decorators/constants.py 100.00% <100.00%> (ø)
azure/functions/decorators/function_app.py 99.34% <100.00%> (+0.03%) ⬆️
azure/functions/decorators/sql.py 100.00% <100.00%> (ø)

@gavin-aguiar
Copy link
Contributor

Can you update this doc? https://github.com/Azure/azure-functions-python-library/blob/dev/docs/ProgModelSpec.pyi

@lucyzhang929 lucyzhang929 marked this pull request as draft August 1, 2023 15:20
@lucyzhang929 lucyzhang929 marked this pull request as ready for review August 2, 2023 18:10
@vrdmr vrdmr changed the title Add sql decorator Add SQL decorator Aug 31, 2023
@vrdmr vrdmr changed the title Add SQL decorator Add SQL Decorator for V2 model. Aug 31, 2023
@gavin-aguiar gavin-aguiar merged commit 71f756b into Azure:dev Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FeatureRequest] Azure SQL binding
2 participants