-
Notifications
You must be signed in to change notification settings - Fork 71
No temporary loop for ASGI middleware #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
"compatible with Python 3.7+" Python 3.6 is failing. Are we still supporting 3.6? |
Codecov Report
@@ Coverage Diff @@
## dev #148 +/- ##
==========================================
- Coverage 90.26% 90.09% -0.18%
==========================================
Files 51 51
Lines 2999 2998 -1
Branches 797 796 -1
==========================================
- Hits 2707 2701 -6
- Misses 215 220 +5
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
3.6 isn't supported anymore, I could add a shim for this PR to get the 3.6 test passing, but it would add extra software debt to the project for no reason. |
|
Suggest merging after Azure/azure-functions-python-worker#152 |
|
@YunchuWang this is passing now, ready to merge |
Fixes #164
get_event_loop() is deprecated in Python 3.10, but the replacement, get_running_loop() will raise a runtime error if there is no event loop, so
asyncio.run()is a better solution, compatible with Python 3.7+.