Skip to content

Adding support for Linger.ms #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Adding support for Linger.ms #407

merged 4 commits into from
Dec 14, 2022

Conversation

shrohilla
Copy link
Contributor

@shrohilla shrohilla commented Dec 10, 2022

Adding the support for linger.ms configuration for the customer for output binding.

A commonly adjusted configuration property on the producer is LingerMs - the minimum time between batches of messages being sent to the cluster. Larger values allow for more batching, which increases throughput. Smaller values may reduce latency. The tradeoff is complicated somewhat as throughput increases though because a smaller LingerMs will result in more broker requests, putting greater load on the server, which in turn may reduce throughput.

This change doesn't requires the new unit test cases nor the e2e test cases.

@shrohilla shrohilla marked this pull request as draft December 10, 2022 07:55
@Azure Azure deleted a comment from azure-pipelines bot Dec 10, 2022
@shrohilla shrohilla marked this pull request as ready for review December 10, 2022 08:02
@shrohilla
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@shrohilla shrohilla marked this pull request as draft December 10, 2022 08:08
Base automatically changed from shrohilla/producer-perf to dev December 11, 2022 06:18
Copy link
Contributor

@lpapudippu lpapudippu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrohilla shrohilla merged commit 82de332 into dev Dec 14, 2022
@shrohilla shrohilla deleted the shrohilla/lingerms branch December 14, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants