Updates in the samples #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jainharsh98
reviewed
Aug 1, 2022
samples/java/confluent/src/main/java/com/contoso/kafka/KafkaTriggerRetry.java
Outdated
Show resolved
Hide resolved
…tions-kafka-extension into shrohilla/retry-samples
jainharsh98
reviewed
Aug 1, 2022
Currently we don't have the specific samples for the certificates so we have to live with this, customer who don't require can remove that |
But this might create confusion for customers on whether sslCaLocation for powershell and confluent is required or not. My recommendation would be to keep only the required code. Otherwise LGTM. |
jainharsh98
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the samples with incorporation of comments