Python and Java Tests with E2E testing Framework #354

jainharsh98 · 2022-06-21T06:46:31Z

Adds a framework for testing the extension with azure functions across different languages with managed kafka offerings.

Current PR adds test cases for -

Confluent
Eventhub

and Languages -

Java
Python

Language End to End Testing for PR

Function Apps for Lang E2E

* Adding Async Functions * Adding Get Http call * Added Single Event Test Function App for Dotnet * Added Dockerfile and Multi Kafka Trigger in dotnet * Updated Multi Kafka Output Binding in dotnet * Testing Http and Command Utilities * Cleaning implementation * Adding Constants and BrokerType * Adding env flag in docker commands * Correcting Dotnet Confluent Dockerfile * Removing dependence of Apptype from initialization code * Adding Test Assert * Renaming Python Test to include BrokerType * Adding Env Variables for Eventhub * Adding Python Constants and env variables * Removing FunctionsApps from Build * Fixing Build Issues * Correcting Dotnet Functions Apps * Removing Extra Python App Co-authored-by: krishna-kariya <kkariya@microsoft.com> Co-authored-by: krishna-kariya <89184055+krishna-kariya@users.noreply.github.com>

Utilities for E2E framewok

* Adding Process Manager and Cleanup Class * Making response list private * Added and Tested Python Apps * Adding Java Test Cases * Adding Env Variables to Azure Pipeline * Commenting Unit Test * Docker Build for python and java local broker test * Commenting Old Language Tests * Commenting Local Kafka Startup * Adding Http log and Powershell command * Adding additional logs for eventhub * Modifying Ubuntu Command in pipeline * Modifying Process Executor for Linux environments * Adding additional tests and correcting function app * Changing Eventhub Namespace * Adding semaphore for eventhub client access * Allowing Max threads for async operations * Correcting Dotnet Isolated Functions * Commenting old docker builds * Commenting old docker builds * Correcting Mistake in dotnet isolated csproj * Adding logs for http request response * Adding exception logging for function invocation * Code Cleanup * Correcting Azure Pipeline * Updating dotnet isolated function apps * mend * Uncommenting DotnetIsolated Confluent Test and changing Port number * Changing Typescript Eventhub app port to a random port Co-authored-by: krishna-kariya <kkariya@microsoft.com>

shrohilla · 2022-06-29T06:28:04Z

@jainharsh98 build is failing please fix that

Could you please add the context in the description what exactly is the scope of this PR.

shrohilla · 2022-07-04T09:45:05Z

@jainharsh98 Could you please add a readme file for the E2E understanding for configs setup for local

…e-functions-kafka-extension into jainh/e2e-python-test

...ns.Kafka.LangEndToEndTests/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests.csproj

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/KafkaLanguageEndToEndTests.cs

shrohilla · 2022-07-08T08:22:30Z

Across all the files we are currently using Console.writeline, can we move them on Logger if possible ??
Can we add comments over the files to know the complete scope
Can we add the ReadMe file for understanding the configuration required for local setup for a new user

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Util/Util.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Type/AppType.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Util/Constants.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Entity/KafkaEntity.cs

...ft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Queue/AzureStorageQueueManager.cs

...Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Queue/KafkaQueueManager.cs

...icrosoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Entity/HttpRequestEntity.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Queue/QueueResponse.cs

...ft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Queue/AzureStorageQueueManager.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Queue/IQueueManager.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/TestSuitInitializer.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Command/HttpCommand.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/TestLogger.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/BaseE2E.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/KafkaE2EFixture.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/TestSuitInitializer.cs

...ft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Command/Shell/DockerRunCommand.cs

mukundnigam · 2022-08-09T04:28:20Z

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/TestLogger.cs

+/* Provides a static logger instance for logging throughout the framework.
+* This is needed as xunit framework does not support dependency injection directly.
+*/
+internal static class TestLogger


I think you intend to make this a singleton class? In that case you can create it as a singleton pattern.You can keep class as non-static.

Sure. We are planning to have a separate work item for logging improvement.

I think Logger needs to be improved with thi PR only, this logger looks incomplete and doesn't holds the guarantees of debugging the test

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Tests/JavaEventhubAppTest.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/TestSuitInitializer.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/TestSuiteCleaner.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/KafkaE2EFixture.cs

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Tests/PythonEventhubAppTest.cs

shrohilla · 2022-08-09T05:58:37Z

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Command/QueueCommand.cs

+		_queueType = queueType;
+		_queueName = queueName;
+		_queueOperation = queueOperation;
+		if (QueueType.EventHub == queueType)


L22-29 looks like a factory pattern approach shall we refactor this to a factory class ??

Sure. We can take this up in the improvement task.

I think it's a small task can be taken care in the same PR

shrohilla

Logger functionality is not sufficient, let's fix that in the same PR

ghost · 2022-09-20T06:02:49Z

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

lpapudippu

Looks good to me.

shrohilla and others added 19 commits March 2, 2022 10:03

initial commit for skeleton

601422b

incorporation of review comment

ccc12c8

removing author name

2ea4990

adding the queue operations and adding more TODO comments

a518c35

Merge pull request #293 from Azure/shrohilla/e2e-skeleton

6ffb2b3

Language End to End Testing for PR

Created function apps for all runtime

5d15e1a

Merge pull request #301 from Azure/kkariya/funcapp-e2e

e175ae5

Function Apps for Lang E2E

Added xunit.runner.json to enable parallelism

e7550f5

Added Creation of EventHubs

1bd504d

Added support for deleting eventhubs and storage queue utilities

63cf679

Merge pull request #302 from Azure/kkariya/utilities

551816a

Utilities for E2E framewok

Merge all e2e changes with latest code

fff9cb1

Rename ProcessManager to ProcessLifecycleManager

e53d987

Code Cleaning

81eae03

Reducing scope to java and python

7e38f69

Cleanup for Java Functions

3c1af2a

Merge branch 'dev' into jainh/e2e-python-test

3d28bc6

jainharsh98 requested review from lpapudippu and shrohilla June 21, 2022 06:46

jainharsh98 added 3 commits July 5, 2022 20:19

Upgrading Library

d28e811

Merge branch 'jainh/e2e-python-test' of https://github.com/Azure/azur…

84190d6

…e-functions-kafka-extension into jainh/e2e-python-test

Correcting app type in python eventhub test

d7cbb3a

shrohilla reviewed Jul 8, 2022

View reviewed changes

...ns.Kafka.LangEndToEndTests/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests.csproj Outdated Show resolved Hide resolved

shrohilla reviewed Jul 8, 2022

View reviewed changes

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/KafkaLanguageEndToEndTests.cs Outdated Show resolved Hide resolved

shrohilla reviewed Jul 8, 2022

View reviewed changes

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Util/Util.cs Outdated Show resolved Hide resolved

Updating Azure.ResourceManager Nugets

56cf3ee

mukundnigam reviewed Aug 2, 2022

View reviewed changes

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/TestSuitInitializer.cs Outdated Show resolved Hide resolved

jainharsh98 added 4 commits August 8, 2022 11:59

Merge branch 'dev' into jainh/e2e-python-test

29606bd

Code Cleanup and azure library upgrade

adbad16

Cleaning ClearAsync method for Storage Queue

d56d50f

Moved common types to common folder

af935a8

shrohilla reviewed Aug 8, 2022

View reviewed changes

test/Microsoft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Command/HttpCommand.cs Outdated Show resolved Hide resolved

Renaming command interface to IExecutableCommand

7819a43

mukundnigam reviewed Aug 8, 2022

View reviewed changes

Improve code formatting

c86ca89

shrohilla reviewed Aug 8, 2022

View reviewed changes

...ft.Azure.WebJobs.Extensions.Kafka.LangEndToEndTests/Common/Command/Shell/DockerRunCommand.cs Show resolved Hide resolved

mukundnigam reviewed Aug 9, 2022

View reviewed changes

shrohilla reviewed Aug 9, 2022

View reviewed changes

jainharsh98 added 4 commits August 11, 2022 12:35

merge latest code

08cd103

Creating separate fixtures for language and broker combinations

1d70935

Remove obsolete isInitialized from KafkaFixture

5acc619

Merge branch 'dev' into jainh/e2e-python-test

520ce09

shrohilla suggested changes Sep 13, 2022

View reviewed changes

ghost added the Needs: author feedback label Sep 13, 2022

ghost added the no recent activity label Sep 20, 2022

ghost closed this Sep 27, 2022

jainharsh98 reopened this Sep 30, 2022

ghost removed Needs: author feedback no recent activity labels Sep 30, 2022

Merge branch 'dev' into jainh/e2e-python-test

d4dc798

lpapudippu approved these changes Sep 30, 2022

View reviewed changes

Merge branch 'dev' into jainh/e2e-python-test

0b928e1

lpapudippu merged commit 6ef333b into dev Oct 17, 2022

Python and Java Tests with E2E testing Framework #354

Python and Java Tests with E2E testing Framework #354

Uh oh!

Conversation

jainharsh98 commented Jun 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shrohilla commented Jun 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shrohilla commented Jul 4, 2022

Uh oh!

Uh oh!

Uh oh!

shrohilla commented Jul 8, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mukundnigam Aug 9, 2022

Choose a reason for hiding this comment

Uh oh!

jainharsh98 Sep 13, 2022

Choose a reason for hiding this comment

Uh oh!

shrohilla Sep 13, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shrohilla Aug 9, 2022

Choose a reason for hiding this comment

Uh oh!

jainharsh98 Sep 13, 2022

Choose a reason for hiding this comment

Uh oh!

shrohilla Sep 13, 2022

Choose a reason for hiding this comment

Uh oh!

shrohilla left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Sep 20, 2022

Uh oh!

lpapudippu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jainharsh98 commented Jun 21, 2022 •

edited

Loading

shrohilla commented Jun 29, 2022 •

edited

Loading