Skip to content

Sdktypes bug fix #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: dev
Choose a base branch
from
Open

Sdktypes bug fix #823

wants to merge 25 commits into from

Conversation

ahmedmuhsin
Copy link
Contributor

@ahmedmuhsin ahmedmuhsin commented Jun 3, 2025

This pull request introduces enhancements to Azure Functions Java SDK types testing, updates dependencies, and simplifies CI pipelines. While working on adding a blob input sample I found a couple of small bugs in the SdkTypesMiddleware.

SdkTypesMiddleware Bug Fixes

  • The getDataByName call was not getting data from the correct inputsource when there are multiple input sources. I reverted the method back to its original implementation (before sdktypes support) and added a new helper that specifically looks up data in the correct input source.
  • Added a missing parseAndVerify() call to the sdk type creation process. This missing call was causing the cache key to always be blank.
  • I added a new emulated test to ensure that these scenarios are covered.

Emulated Testing Enhancements:

  • Introduced a new test BlobTriggerToBlob_FromBlobInput_BlobClient_Succeeds() in StorageEndToEndTests.cs to validate blob input binding functionality.

Dependency Updates:

  • Upgraded Maven plugin version to 1.38.0 in pom.xml to ensure compatibility with the latest features.
  • Updated azure.functions.java.sdktypes dependency to version 1.0.1 in pom.xml.

CI Pipeline Simplifications:

  • Removed conditional logic for SDK types testing from public-build.yml, run-emulated-tests-linux.yml, and run-emulated-tests-windows.yml. This includes the elimination of runSdkTypesTests parameter and associated steps. [1] [2] [3]
  • Simplified CI test configurations by removing redundant scripts and conditional SDK types testing logic. [1] [2]
  • Added a new constant JAVA_ENABLE_SDK_TYPES in Constants.java to enable SDK types testing uniformly across environments.
  • Removed local installation of dependencies since everything can now be downloaded off of maven.

CI Pipeline Fixes:

  • Fix tests for JDK 17+ on Linux
  • Properly install the required JDK version using the JavaToolInstaller (we were by mistake always testing JDK 8, the built-in version)

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@ahmedmuhsin ahmedmuhsin force-pushed the sdktypes-bug-fix branch 6 times, most recently from 7c78aaf to e3c3034 Compare June 4, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant