Please remove "jna-platform" dependency from project #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the following dependency from the project.
Because it was not used in the code.
```xml
<dependency>
<groupId>net.java.dev.jna</groupId>
<artifactId>jna-platform</artifactId>
<version>5.12.1</version>
</dependency>
```
yoshioterada
requested review from
anirudhgarg,
TsuyoshiUshio,
amamounelsayed,
kaibocai and
shreyas-gopalakrishna
as code owners
|
At first, https://github.com/Azure/azure-functions-host/wiki/Language-Extensibility Then I noticed that the above class lib is not necessary anymore for the project. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kaibocai san, According to the Azure Pipelines, it failed due to some tests. Build log #L894 |
|
Hi @yoshioterada san, sorry I was out last week. I will confirm the error log with you asap. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @yoshioterada san, I attached part of the failures log Seems we are using this dependency in our e2e pipeline. I will take sometime look into it and keep you update. Thanks. |
7 tasks
|
Hi @yoshioterada san, can you do me a favor, that you add it back in this pr and we run the pipeline again, it seems CI failed because of your forked branch not really the change you made, want to confirm. Thank you. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The PR #670 has merged, Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please remove the following dependency from the project. Because it was not used in the project.
Issue describing the changes in this PR
Removed unused dependency from project file.
Pull request checklist
release_notes.mdAdditional information
After I fork the project, I noticed that the above dependency was not used in the project.
So if you removed the library, you could reduce the size of artifacts as follows.
> ls -l -rw-r--r-- 1 teradayoshio staff 22983908 9 27 22:40 azure-functions-java-worker-2.6.1-SNAPSHOT.jar> ls -l -rw-r--r-- 1 teradayoshio staff 19591598 9 27 22:41 azure-functions-java-worker-2.6.1-SNAPSHOT.jar