Use a single classloader for java 11 if environment variable is set #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-gopalakrishna
requested review from
anirudhgarg and
TsuyoshiUshio
as code owners
trask
reviewed
Sep 24, 2021
Comment on lines
43
to
44
| classLoaderInstance = new URLClassLoader(urlsForClassLoader); | ||
| loadDrivers(classLoaderInstance); |
There was a problem hiding this comment.
extract to function to reuse from above also
trask
reviewed
Sep 27, 2021
| synchronized (lock) { | ||
| if (classLoaderInstance == null) { | ||
| URLClassLoader loader = createURLClassLoaderInstance(); | ||
| loadDrivers(loader); |
There was a problem hiding this comment.
looks like loadDrivers can be moved to createURLClassLoaderInstance
trask
previously approved these changes
Sep 28, 2021
Comment on lines
25
to
26
| URLClassLoader classLoader = createURLClassLoaderInstance(); | ||
| return classLoader; |
There was a problem hiding this comment.
Suggested change
| URLClassLoader classLoader = createURLClassLoaderInstance(); | |
| return classLoader; | |
| return createURLClassLoaderInstance(); |
Comment on lines
38
to
39
| URLClassLoader loader = createURLClassLoaderInstance(); | ||
| classLoaderInstance = loader; |
There was a problem hiding this comment.
Suggested change
| URLClassLoader loader = createURLClassLoaderInstance(); | |
| classLoaderInstance = loader; | |
| classLoaderInstance = createURLClassLoaderInstance(); |
shreyas-gopalakrishna
force-pushed
the
shreyas-gopalakrishna/v3-classloader
branch
from
dbf959e to
657667a
Compare
trask
previously approved these changes
Sep 28, 2021
shreyas-gopalakrishna
force-pushed
the
shreyas-gopalakrishna/v3-classloader
branch
from
657667a to
cd0f7d5
Compare
amamounelsayed
approved these changes
Sep 29, 2021
shreyas-gopalakrishna
deleted the
shreyas-gopalakrishna/v3-classloader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
FUNCTIONS_WORKER_JAVA_SINGLE_CLASSLOADERenvironment variable is set to true then the following changes are made#412