Add AppServiceEnvironment profile #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewc
reviewed
Jul 30, 2018
worker.config.json
Outdated
| } | ||
| }, | ||
| "profiles": { | ||
| "AppServiceEnvironment": { |
There was a problem hiding this comment.
nit: looks like your tabs/spacing are off here
mathewc
previously approved these changes
Jul 30, 2018
fabiocav
reviewed
Jul 31, 2018
| "DefaultWorkerPath":"azure-functions-java-worker.jar", | ||
| "Arguments" : ["-jar"] | ||
| "Description": { | ||
| "Language": "java", |
There was a problem hiding this comment.
This is unrelated to your changes, but at some point, it would be nice to go over the casing on these files and make sure they are consistent. All these should be camel cased.
There was a problem hiding this comment.
👍 opened Azure/azure-functions-host#3214 as I need to make changes do not break any of the language workers
fabiocav
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.