Added support to gracefully shutdown language worker #8385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
reviewed
May 18, 2022
test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/SamplesEndToEndTests_Java.cs
Outdated
Show resolved
Hide resolved
kshyju
reviewed
May 18, 2022
liliankasem
reviewed
May 20, 2022
liliankasem
reviewed
Jun 30, 2022
liliankasem
reviewed
Jun 30, 2022
liliankasem
approved these changes
Jul 25, 2022
liliankasem
reviewed
Jul 26, 2022
| }); | ||
|
|
||
| WorkerProcess.WaitForProcessExit(); | ||
| WorkerProcess.WaitForProcessExitInMilliSeconds(gracePeriod * 1000); |
There was a problem hiding this comment.
super nit here, but I don't feel we need to change the name, the method definition/summary should be enough to indicate if the parameter it takes is milliseconds or second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #2308
Design doc
Sending a WorkerTerminate message from host to worker to allow the worker to terminate itself gracefully instead of immediately killing it. Refer #3296 for more details.
Pull request checklist
release_notes.mdAdditional information
Additional PR information