[Under a feature flag] Removing duplicates #4660
Conversation
| @@ -178,7 +178,6 @@ public static TypedData ToRpc(this object value, ILogger logger, Capabilities ca | |||
| } | |||
|
|
|||
| request.Body.Position = 0; | |||
| http.Body = body.ToRpc(logger, capabilities); | |||
There was a problem hiding this comment.
Unless this is driven by worker capabilities, it will introduce a change that will require language worker updates. Ideally, this would be done in a non-breaking, backwards compatible way (i.e. the capability needs to be advertised by the worker)
There was a problem hiding this comment.
I recommended @yojagad to first try with other languages as this issue is very likely just with nodejs worker. Other language workers might not be relying on the duplicates.
yojagad
changed the title
yojagad
changed the title
| http.RawBody = rawBodyString.ToRpc(logger, capabilities); | ||
| } | ||
| request.Body.Position = 0; | ||
| http.Body = body.ToRpc(logger, capabilities); |
There was a problem hiding this comment.
@maiqbal11 - Can you confirm if python worker send IsRawBodyBytesRequested by default?
yojagad
changed the title
ghost
added
src/WebJobs.Script/Rpc/MessageExtensions/RpcMessageConversionExtensions.cs
Outdated
Show resolved
Hide resolved
test/WebJobs.Script.Tests/Rpc/RpcMessageConversionExtensionsTests.cs
Outdated
Show resolved
Hide resolved
test/WebJobs.Script.Tests/Rpc/RpcMessageConversionExtensionsTests.cs
Outdated
Show resolved
Hide resolved
test/WebJobs.Script.Tests/Rpc/RpcMessageConversionExtensionsTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks great, thanks Yogesh!
Feel free to open issues in other language worker repos with context to consume the change.
One small thing - can you wait for a build of the nodejs-worker PR tests to pass before merging this change? just to be extra safe (want to make sure the nodejs e2e tests pass before and after this change is merged!)
Attempting to fix #3845
Test status:
Node: Passed (corresponding PR Azure/azure-functions-nodejs-worker#234)
Java: Tracking issue (Azure/azure-functions-java-worker#319)
Powershell: Tracking issue (Azure/azure-functions-powershell-worker#292)
Python: Pending verification form @maiqbal11 as to whether this already supported.