Fetch Host JIT trace files from functions-release at build time#11722
Open
Francisco-Gamino wants to merge 5 commits intodevfrom
Open
Fetch Host JIT trace files from functions-release at build time#11722Francisco-Gamino wants to merge 5 commits intodevfrom
Francisco-Gamino wants to merge 5 commits intodevfrom
Conversation
…ld time The JIT trace files in src/WebJobs.Script.WebHost/PreJIT/ were stale because the canonical source of truth moved to the functions-release repo (artifacts/Host/JitTrace/dev/). This change: - Deletes coldstart.jittrace and linux.coldstart.jittrace from PreJIT/ - Adds functions-release as an ADO repository resource in host.coldstart.yml - Adds checkout + copy steps in run-coldstart.yml to place the latest JIT trace files in PreJIT/ before dotnet publish - Extracts the repo path to jitTraceRepoPath variable in coldstart.yml - No changes to the .csproj glob (PreJIT\*.jittrace) or merge-jittrace.yml
The 1ES Pipeline Template requires non-self repositories used in multi-checkout to be declared in sdl.sourceRepositoriesToScan. Since functions-release is only used to copy JIT trace files, exclude it from SDL source analysis.
Francisco-Gamino
requested review from
a team,
eliaslopezgt,
pragnagopa and
vrdmr
as code owners
11 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the coldstart pipeline to source Host PreJIT .jittrace files from the functions-release repo at build time instead of keeping them in this repo, ensuring the host publish output still contains the required trace files.
Changes:
- Added a pipeline variable for the
functions-releaseJIT trace directory path. - Added multi-repo checkout and a PowerShell step to copy required
.jittracefiles intosrc/WebJobs.Script.WebHost/PreJIT/, failing the job if missing. - Added
functions-releaseas a pipeline resource and excluded it from SDL source scanning; logsrelease_notes.mdcontent from the trace directory.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/ci/templates/variables/coldstart.yml | Introduces a variable pointing to the functions-release JIT trace directory. |
| eng/ci/templates/official/jobs/run-coldstart.yml | Adds repo checkouts + copy/validation step to bring .jittrace files into the publish input. |
| eng/ci/host.coldstart.yml | Adds functions-release as a repository resource and adjusts SDL scanning settings. |
- Remove leading / from jitTraceRepoPath variable - Use Join-Path for cross-platform path construction - Prefix release notes lines to prevent ##vso log command injection
kshyju
reviewed
Apr 22, 2026
| @@ -1,2721 +0,0 @@ | |||
| [Azure.Core]Azure.Core.AppContextSwitchHelper.GetConfigValue(string,string)~Azure.Core.AppContextSwitchHelper,Azure.Core~2~0~GetConfigValue | |||
Member
There was a problem hiding this comment.
Should we add a warning log in HostWarmupMiddleware so that anyone running locally and simulating placeholder mode is notified when the file is missing? We should also update the local host specialization wiki page to explain where to download the file for local runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
The JIT trace files in
PreJIT/have been moved tofunctions-release(artifacts/Host/JitTrace/dev/).Changes
coldstart.jittraceandlinux.coldstart.jittracefromsrc/WebJobs.Script.WebHost/PreJIT/coldstart.jittraceandlinux.coldstart.jittracebefore dotnet publishrelease_notes.mdcontent from the JIT trace directoryUnchanged
.csprojglob (PreJIT\*.jittrace),merge-jittrace.yml,.jitmarker,JitTraceRuntime.csTesting
host.coldstartdef 1286)createJitTrace=false) completes successfullycreateJitTrace=trueproduces valid merged JIT trace artifactsPull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Additional PR information