FileSystemReadOnly when functions running in ACA environment #11338
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Sets Functions running on Azure Container Apps to use a read-only file system by default by short-circuiting in the zip/run-from-package detection logic.
- Adds an early return in IsZipDeployment when running in a Managed (Container Apps) environment.
- Updates XML doc comment to clarify that Managed App environment refers to Azure Container Apps.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/WebJobs.Script/Environment/EnvironmentExtensions.cs | Comment clarified to reference Azure Container Apps. |
| src/WebJobs.Script.WebHost/Configuration/ScriptApplicationHostOptionsSetup.cs | Added early return treating Container Apps as read-only (run-from-package equivalent). |
src/WebJobs.Script.WebHost/Configuration/ScriptApplicationHostOptionsSetup.cs
Outdated
Show resolved
Hide resolved
added 2 commits
September 19, 2025 15:58
krishnajaju
requested review from
mathewc,
brettsam,
vivekjilla and
manikantanallagatla
mathewc
reviewed
Sep 19, 2025
| @@ -66,7 +66,7 @@ public void Configure(string name, ScriptApplicationHostOptions options) | |||
| options.IsStandbyConfiguration = true; | |||
| } | |||
|
|
|||
| options.IsFileSystemReadOnly |= IsZipDeployment(out bool isScmRunFromPackage); | |||
| options.IsFileSystemReadOnly |= IsZipDeployment(out bool isScmRunFromPackage) || _environment.IsManagedAppEnvironment(); | |||
There was a problem hiding this comment.
Recommend moving your logic into IsZipDeploymente so it's consistent with the other skus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Set IsFileSystemReadOnly to true by default for Functions on Container Apps to prevent unintended file system behaviours
resolves #11337
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Additional PR information