Skip to content

[in-proc] Test Fix #10975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

[in-proc] Test Fix #10975

merged 1 commit into from
Mar 31, 2025

Conversation

satvu
Copy link
Member

@satvu satvu commented Mar 31, 2025

Issue describing the changes in this PR

Fixes failing test. Both #10958 and #10942 modified the same test file, resulting in a rename of a test helper method being overwritten. PR validations did not catch the issue.

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@satvu satvu requested a review from a team as a code owner March 31, 2025 19:46
@satvu satvu merged commit 00bc42c into in-proc Mar 31, 2025
9 checks passed
@satvu satvu deleted the satvu/in-proc/test-fix branch March 31, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants