[Bug Fix] Refactor Linux container management to avoid race condition that leads the host to initialize placeholder (warmup) function #10848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satvu
commented
Feb 14, 2025
jviau
reviewed
Feb 14, 2025
src/WebJobs.Script.WebHost/ContainerManagement/LinuxContainerInitializationHostedService.cs
Outdated
Show resolved
Hide resolved
jviau
reviewed
Feb 14, 2025
satvu
commented
Feb 19, 2025
test/WebJobs.Script.Tests.Integration/Management/InstanceManagerTests.cs
Outdated
Show resolved
Hide resolved
jviau
reviewed
Feb 25, 2025
...ript.Tests.Integration/ContainerManagement/AtlasContainerInitializationHostedServiceTests.cs
Show resolved
Hide resolved
test/WebJobs.Script.Tests.Integration/Management/InstanceManagerTests.cs
Outdated
Show resolved
Hide resolved
test/WebJobs.Script.Tests.Integration/Management/InstanceManagerTests.cs
Show resolved
Hide resolved
satvu
commented
Feb 26, 2025
satvu
commented
Feb 26, 2025
src/WebJobs.Script.WebHost/ContainerManagement/LinuxContainerInitializationHostedService.cs
Show resolved
Hide resolved
fabiocav
reviewed
Feb 27, 2025
jviau
reviewed
Feb 27, 2025
...ript.Tests.Integration/ContainerManagement/AtlasContainerInitializationHostedServiceTests.cs
Outdated
Show resolved
Hide resolved
jviau
reviewed
Mar 3, 2025
jviau
approved these changes
Mar 4, 2025
fabiocav
reviewed
Mar 14, 2025
fabiocav
approved these changes
Mar 25, 2025
satvu
added a commit
that referenced
this pull request
Mar 26, 2025
… that leads the host to initialize placeholder (warmup) function (#10848)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #10725
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not required*** Otherwise: Link to backporting PR** - backport PR
release_notes.mdThis change introduces a new, asynchronous method for assigning an instance in order to resolve the race condition described in #10725. It also maintains the existing "fire and forget" method which is necessary for the HTTP call here in the instance controller.
This PR also includes a refactor of flaky tests, removing calls of
Task.Delay()and switching to the use of the async method for multiple E2E and integration scenarios.