Refactor/Baseline Unit Tests #6
Conversation
# Conflicts: # .vscode/settings.json
|
|
||
|
|
||
| # pycharm | ||
| .idea |
There was a problem hiding this comment.
Can remove pycharm based files.
There was a problem hiding this comment.
Remove them from the .gitignore? That would add the files to the github repo. We have the .vscode files there, but I usually try to avoid putting IDE specific files especially when there are dev machine specific configurations in them. I can see the value in adding the .vscode files here as they have none dev machine specific configuration in there. Not the case for the pycharm files.
| @@ -7,5 +7,5 @@ def __init__(self): | |||
| self.EventType: HistoryEventType | |||
| self.EventId: int | |||
| self.IsPlayed: bool | |||
| self.Timestamp: datetime | |||
| self.Timestamp: str | |||
There was a problem hiding this comment.
Is there a reason why Timestamp is changed to a str type?
There was a problem hiding this comment.
Was receiving an error. Timestamp as json is a string value, a conversion stepis required to get it into a datetime. The dtparse is required/already being used to convert the string to a date prior to processing.
e.g. self.currentUtcDateTime = dtparse(decisionStartedEvent["Timestamp"])
Resolves #5