Skip to content

add .flake file and fix flake8 errors #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 21, 2020
Merged

add .flake file and fix flake8 errors #21

merged 10 commits into from
Jan 21, 2020

Conversation

shervyna
Copy link

@shervyna shervyna commented Jan 17, 2020 •
edited
Loading

resolves #22

  • fix all lint errors
  • add .flake file
  • add flake8-docstring to requirments.txt
  • remove --exit-zero in azure-pipeline.yml
  • change fixture.py to conftest.py (if we import fixtures from fixtures.py, lint gives redefinition of unused {fixture_name} error. explained in this link https://gitlab.com/pycqa/flake8/issues/520)

I am ignoring "missing docstrings"rules because there are too much missing to write it up at this moment

@shervyna shervyna self-assigned this Jan 17, 2020
@shervyna
Copy link
Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@priyaananthasankar priyaananthasankar merged commit 567fbb7 into Azure:dev Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyaananthasankar priyaananthasankar priyaananthasankar approved these changes

@codepossible codepossible codepossible approved these changes

@scgbear scgbear Awaiting requested review from scgbear

Assignees

@shervyna shervyna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make flake8 errors block build checks, fix all lint errors
3 participants
@shervyna @priyaananthasankar @codepossible