Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ActivityInputConverter for Activities with FunctionContext-only parameters #2806

Merged
merged 2 commits into from
May 1, 2024

Conversation

nytian
Copy link
Contributor

@nytian nytian commented May 1, 2024

Fix issue #2741

When activity functions with only one parameter, the FunctionContext, would incorrectly have the FunctionContext set to null after ConvertAsync() at ActivityInputConverter. That's because the ContextConverter handles the source as null and TargetType as FunctionContext. This PR adds a specific case in the ActivityInputConverter to address this issue.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
  • My changes should be added to v3.x branch.
    • Otherwise: This change only applies to Durable Functions v2.x and will not be merged to branch v3.x.

@nytian nytian marked this pull request as ready for review May 1, 2024 17:41
@nytian nytian requested a review from jviau May 1, 2024 17:45
@nytian
Copy link
Contributor Author

nytian commented May 1, 2024

The E2E test I made:
Original error:
image

After changes in this PR
image

@nytian nytian requested a review from jviau May 1, 2024 18:44
@nytian nytian merged commit eee1aee into dev May 1, 2024
20 checks passed
@nytian nytian deleted the nytian/fix_activity_converter branch May 7, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants