Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ControlQueueBufferThreshold defaults in Consumption #1846

Merged
merged 5 commits into from
May 25, 2021

Conversation

davidmrdavid
Copy link
Contributor

@davidmrdavid davidmrdavid commented May 24, 2021

We recently learned that some customers are experiencing increased latency in their orchestration completion times in the Consumption plan. This is because we recently (#1706) changed our concurrency defaults in the Consumption plan to accommodate its resource constraints and scaling behavior.

In that process, we decreased the value of ControlQueueBufferThreshold from 256 to just 32. That decrease appears to blame for the increased latency.

This PR increases the default for JS and C# to be 128, a less dramatic decrease from 256. For Python, we keep the default as 32 as we theorize that the Python language worker would benefit from a small ControlQueueBufferThreshold value.

This PR comes as a bit of a hot-patch and is subject to change in the future. In particular, we have a pending work item (#1700) to come up with PL-aware concurrency defaults, as well as improving the design of the IPlatformInformationService interface. Those changes are still pending.

Issue describing the changes in this PR

Relates to #1842

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Copy link
Contributor

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidmrdavid davidmrdavid merged commit 0738b8b into dev May 25, 2021
@davidmrdavid davidmrdavid deleted the dajusto/increase-consumption-concurrency branch May 25, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants