-
Notifications
You must be signed in to change notification settings - Fork 201
[MSBUILD SDK] Add general msbuild props, use worker SDK #3176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add initial Azure.Functions.Sdk project * dotnet isolated -> dotnet-isolated
b5c53b4 to
7ddb82c
Compare
7ddb82c to
6635575
Compare
7a23861 to
7045b0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new MSBuild SDK (Azure.Functions.Sdk) that will eventually replace the existing Microsoft.Azure.Functions.Worker.Sdk. The new SDK leverages Microsoft.NET.Sdk.Worker as its base to provide enhanced features like automatic content file copying, default project configurations, and improved Visual Studio integration.
Key Changes:
- Creates the new
Azure.Functions.Sdkproject with MSBuild props/targets files that import and build uponMicrosoft.NET.Sdk.Worker - Adds default package reference to
Microsoft.Azure.Functions.Workerv2.0.0 and configures Azure Functions tooling integration - Updates CI pipeline to include feature branches in code mirroring
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Azure.Functions.Sdk/Azure.Functions.Sdk.csproj | Defines the SDK project structure and packaging configuration |
| src/Azure.Functions.Sdk/Sdk/Sdk.props | Entry point props file that sets SDK flag and imports target-specific props |
| src/Azure.Functions.Sdk/Sdk/Sdk.targets | Entry point targets file that defines task paths and imports target-specific targets |
| src/Azure.Functions.Sdk/Targets/Azure.Functions.Sdk.props | Core props file that imports Worker SDK, sets defaults, and adds package references |
| src/Azure.Functions.Sdk/Targets/Azure.Functions.Sdk.targets | Core targets file that imports Worker SDK targets and configures Functions tooling |
| src/Azure.Functions.Sdk/Build/Azure.Functions.Sdk.targets | Guard targets to prevent incorrect PackageReference usage |
| src/Azure.Functions.Sdk/README.md | Documents the purpose of the new SDK |
| eng/ci/code-mirror.yml | Enables code mirroring for feature branches |
| DotNetWorker.sln | Adds the new SDK project to the solution |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* Mirror feature branches * Use release tag for eng repo * Add initial Azure.Functions.Sdk project (#3142) * Add initial Azure.Functions.Sdk project * dotnet isolated -> dotnet-isolated * Add some general props to msbuild-sdk * Use Worker sdk internally * Add Azure.Functions.Sdk to sln * Remove new sln configs * Update msbuild package * Update msbuild package * Update msbuild package * Update implicit package to latest
Issue describing the changes in this PR
part of #3131
Pull request checklist
release_notes.mdAdditional information
Adds some basic props to the new msbuild sdk. One major deviation this SDK is taking, is we will be using Microsoft.NET.Sdk.Worker SDK internally. This adds a few features on top of the regular .NET SDK
.contentand.jsonfiles to build & publish output