Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print warning when AddJsonFile is called with "local.settings.json" #2777

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

BogdanYarotsky
Copy link

@BogdanYarotsky BogdanYarotsky commented Oct 13, 2024

Issue describing the changes in this PR

resolves #613

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information.

Hi @fabiocav, this is my first pull request in this repository. I've added a bunch of unit tests and documentation for the new analyzer. Please let me know what you think about this PR and what else should be added to it.

Many Thanks!
Bogdan

@BogdanYarotsky BogdanYarotsky changed the title Local settings json analyzer Print warning when AddJsonFile is called with "local.settings.json" Oct 13, 2024
@BogdanYarotsky
Copy link
Author

@microsoft-github-policy-service agree

@@ -0,0 +1,27 @@
# AZFW0016: Redundant usage of local.settings.json in the worker configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AZFW0016 already exists (recently merged) - can you make this AZFW0017?

Copy link
Contributor

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print warning when AddJsonFile is called with "local.settings.json"
2 participants