Skip to content

Updating signing configuration and version suffix #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Updating signing configuration and version suffix #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,38 @@ jobs:
}
]

- task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1
displayName: 'Sdk: ESRP CodeSigning - Authenticode'
condition: eq(variables.isReleaseBuild, true)
inputs:
ConnectedServiceName: 'ESRP Service'
FolderPath: 'sdk\Sdk.Analyzers\bin\Release'
Pattern: Microsoft.Azure.Functions.Worker.Sdk.Analyzers.dll
signConfigType: inlineSignParams
inlineOperation: |
[
{
"KeyCode": "CP-230012",
"OperationCode": "SigntoolSign",
"Parameters": {
"OpusName": "Microsoft",
"OpusInfo": "http://www.microsoft.com",
"FileDigest": "/fd \"SHA256\"",
"PageHash": "/NPH",
"TimeStamp": "/tr \"http://rfc3161.gtm.corp.microsoft.com/TSS/HttpTspServer\" /td sha256"
},
"ToolName": "sign",
"ToolVersion": "1.0"
},
{
"KeyCode": "CP-230012",
"OperationCode": "SigntoolVerify",
"Parameters": {},
"ToolName": "sign",
"ToolVersion": "1.0"
}
]

- task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1
displayName: 'MetadataLoader: ESRP CodeSigning - Authenticode'
condition: eq(variables.isReleaseBuild, true)
Expand Down Expand Up @@ -118,7 +150,7 @@ jobs:
condition: eq(variables.isReleaseBuild, true)
inputs:
ConnectedServiceName: 'ESRP Service'
FolderPath: 'src\DotNetWorker\bin\Release'
FolderPath: 'src'
Pattern: Microsoft.Azure.Functions.Worker*.dll
signConfigType: inlineSignParams
inlineOperation: |
Expand Down
5 changes: 3 additions & 2 deletions build/Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@
<MinorProductVersion Condition="$(MinorProductVersion) == ''">0</MinorProductVersion>
<PatchProductVersion Condition="$(PatchProductVersion) == ''">0</PatchProductVersion>
<VersionPrefix Condition="$(VersionPrefix) == ''">$(MajorProductVersion).$(MinorProductVersion).$(PatchProductVersion)</VersionPrefix>
<!--If a preview release, this should have the label with the separator (e.g.: -preview1)-->
<VersionSuffix Condition="$(VersionSuffix) == ''"></VersionSuffix>
<IsLocalBuild Condition=" $(IsLocalBuild) == ''">True</IsLocalBuild>
<BuildNumber Condition=" $(IsLocalBuild) == 'True'">local</BuildNumber>
<Version Condition=" '$(BuildNumber)' != '' And $(Version) == ''">$(VersionPrefix)-$(VersionSuffix)-$(BuildNumber)</Version>
<Version Condition=" '$(Version)' == '' ">$(VersionPrefix)-$(VersionSuffix)</Version>
<Version Condition=" '$(BuildNumber)' != '' And $(Version) == ''">$(VersionPrefix)$(VersionSuffix)-$(BuildNumber)</Version>
<Version Condition=" '$(Version)' == '' ">$(VersionPrefix)$(VersionSuffix)</Version>
<AssemblyVersion Condition="$(AssemblyVersion) == ''">$(VersionPrefix).0</AssemblyVersion>
<FileVersion Condition="$(FileVersion) == ''">$(AssemblyVersion)</FileVersion>
<CommitHash Condition="$(CommitHash) == ''">N/A</CommitHash>
Expand Down
2 changes: 1 addition & 1 deletion extensions/Worker.Extensions.RabbitMQ/Worker.Extensions.RabbitMQ.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<!--Version information-->
<MajorProductVersion>1</MajorProductVersion>
<VersionSuffix>beta</VersionSuffix>
<VersionSuffix>-beta</VersionSuffix>
</PropertyGroup>

<Import Project="..\..\build\Extensions.props" />
Expand Down