This repository was archived by the owner on Oct 12, 2023. It is now read-only.
New release #39
Merged
New release #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annatisch
commented
Jul 6, 2018
azure/eventhub/client.py
Outdated
| Run the EventHubClient in blocking mode. | ||
| Opens the connection and starts running all Sender/Receiver clients. | ||
|
|
||
| :rtype: ~azure.eventhub.client.EventHubClient |
Member
Author
There was a problem hiding this comment.
Missing correct docstring
annatisch
commented
Jul 6, 2018
| :param epoch: The epoch value for the receiver. | ||
| :type epoch: int | ||
| :param prefetch: The message prefetch count of the receiver. Default is 300. | ||
| :type prefetch: int |
Member
Author
There was a problem hiding this comment.
Need to add operation to docstring
annatisch
commented
Jul 6, 2018
azure/eventhub/common.py
Outdated
| self._partition_key = types.AMQPSymbol(EventData.PROP_PARTITION_KEY) | ||
| self._annotations = {} | ||
| self._properties = {} | ||
| self._msg_properties = MessageProperties() |
Member
Author
There was a problem hiding this comment.
make properties public?
annatisch
commented
Jul 6, 2018
azure/eventhub/common.py
Outdated
| elif message: | ||
| self.message = message | ||
| self._annotations = message.annotations | ||
| self._properties = message.application_properties |
annatisch
commented
Jul 6, 2018
| output['partition_ids'] = [p.decode('utf-8') for p in eh_info[b'partition_ids']] | ||
| return output | ||
|
|
||
| def add_async_receiver(self, consumer_group, partition, offset=None, prefetch=300, operation=None, loop=None): |
annatisch
commented
Jul 6, 2018
| self.close(exception=error) | ||
| raise error | ||
|
|
||
| def selector(self, default): |
annatisch
commented
Jul 6, 2018
| msg_timeout=Sender.TIMEOUT) | ||
| self._handler.open(connection) | ||
|
|
||
| def get_handler_state(self): |
annatisch
commented
Jul 6, 2018
| msg_timeout=Sender.TIMEOUT) | ||
| await self._handler.open_async(connection=connection) | ||
|
|
||
| async def has_started(self): |
annatisch
commented
Jul 6, 2018
| event_data.message.on_send_complete = lambda o, c: callback(o, Sender._error(o, c)) | ||
| self._handler.queue_message(event_data.message) | ||
|
|
||
| def wait(self): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.