This repository was archived by the owner on Dec 6, 2023. It is now read-only.
update scripts to use Microsoft Graph PowerShell #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#sign-off |
michaeltlombardi
suggested changes
Jul 11, 2023
application-management/export-all-enterprise-apps-secrets-and-certs.ps1
Outdated
Show resolved
Hide resolved
application-management/export-all-enterprise-apps-secrets-and-certs.ps1
Outdated
Show resolved
Hide resolved
application-management/export-all-enterprise-apps-secrets-and-certs.ps1
Outdated
Show resolved
Hide resolved
application-management/export-enterprise-apps-with-expiring-secrets.ps1
Outdated
Show resolved
Hide resolved
michaeltlombardi
approved these changes
Jul 11, 2023
This change refactors the application management sample scripts for: - Clarity, using more descriptive variable names and reducing duplicate code where possible. - Idiomatic practices, replacing aliases and using explicit parameters, replacing `Add-Member` calls with the creation of **PSCustomObject**. - Line length, keeping the script width readable and succinct. This change does not affect the functionality of the scripts, only their presentation. Future changes could include replacing the non-idiomatic read/write host operations with script parameters, which would also allow for validation and in-console help.
michaeltlombardi
force-pushed
the
app-mgmt-samples
branch
from
899cf3b to
3a5a8e1
Compare
sdwheeler
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
@michaeltlombardi I like the code changes. It is much easier to read and change as needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Testing information
Platform and PowerShell version:
[pscustomobject]$PSVersionTable | Select-Object OS, BuildVersion, PSVersionAz version:
(Get-InstalledModule -Name Az).Version