Skip to content
This repository was archived by the owner on Dec 6, 2023. It is now read-only.

Update sample import script to use a valid value for MaxSizeBytes #340

Merged
merged 1 commit into from
May 10, 2021
Merged

Update sample import script to use a valid value for MaxSizeBytes #340

merged 1 commit into from
May 10, 2021

Conversation

sredman
Copy link
Contributor

@sredman sredman commented May 7, 2021

Description

The value previously in use (262144000, which is 250MB) is not a valid size for an S3 database. Trying to create a database of that size will throw an error like The edition 'Standard' does not support the database data max size '262144000'.

I am not clear whether 250MB was ever a valid size for S3, but it certainly is not now. It used to be the case that the Import/Export service would silently swallow this error and just create a database of the max size for the SLO. However, that (buggy) behavior was fixed around November 2020 to respect the parameter.

Checklist

  • This pull request was tested on both of:
  • Scripts do not contain static passwords or other secret tokens.
  • All Azure resource identifiers which must be universally unique are guaranteed to be so.

Testing information

Platform and PowerShell version: 10.0.19041.906, 5.1.19041.906

Az version: 5.2.0

The value previously in use (262144000, which is 250MB) is not a valid size for an S3 database. Trying to create a database of that size will throw an error like `The edition 'Standard' does not support the database data max size '262144000'.`

I am not clear whether 250MB was *ever* a valid size for S3, but it certainly is not now. It used to be the case that the Import/Export service would silently swallow this error and just create a database of the max size for the SLO. However, that (buggy) behavior was fixed around November 2020 to respect the parameter.
@stevestein
Copy link

#sign-off

@stevestein
Copy link

@mikefrobbins - I see another PR pinged you to merge. Thanks!

Copy link
Contributor

@mikefrobbins mikefrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikefrobbins mikefrobbins merged commit d8407e5 into Azure:master May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants