-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix persistSettings regression #4450
Conversation
…s after an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good quick fix to unblock folks but I do think we should revisit (in another PR later) what the error behavior is for non 404 errors.
When azd tries to get the ACA, we use the retry policy from azure-core for non-404 errors, like the 5xx.. If the user gets more non-404 errors for more than 3 times, there would be something else going on beyond this only feature and more things are expected to fail in cascade |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
fix: #4440
Regression analysis.
For azd version 1.10.2, we update the implementation details or deploying container apps (see: #4272).
As part of the change, the logic for persisting existing settings in Aspire deployment changed.
In the past, the logic was validating that an existing aca was not nil, as well as the properties to persist.
This validation was removed as part of the change. See: https://github.com/Azure/azure-dev/pull/4272/files#diff-d6903c0cec59e731280be935e1056d2c8354ade3d82eaa6bfb3652ea31b748afL134-L140
This PR adds a quick exit from persisting settings when the aca is not found or there's an error trying to get it.