fix: Add positional arguments to NoRetryPolicy.should_retry #309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add positional arguments to
NoRetryPolicy.should_retry, so that an exception here will yield the correct behaviour.Otherwise, the error will be
TypeError: should_retry() takes 1 positional argument but 4 were givenwhenNoRetryPolicyis used.This checklist is used to make sure that common guidelines for a pull request are followed.
Description of the change
General Guidelines