Skip to content

Conversation

@elvisace
Copy link
Contributor

Add positional arguments to NoRetryPolicy.should_retry, so that an exception here will yield the correct behaviour.

Otherwise, the error will be TypeError: should_retry() takes 1 positional argument but 4 were given when NoRetryPolicy is used.


This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
  • The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
  • Links to associated bugs, if any, are in the description.

@akharit akharit changed the base branch from master to dev February 12, 2020 18:45
@akharit akharit changed the base branch from dev to master February 12, 2020 18:48
@akharit akharit merged commit 0f9de47 into Azure:master Feb 12, 2020
@akharit
Copy link
Member

akharit commented Feb 12, 2020

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants