Skip to content

Conversation

@akharit
Copy link
Member

@akharit akharit commented Mar 1, 2019


This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

There is a bug in the code where when we encounter len(rfiles)==1, we try to check whether the rpath contained a dir or a file. When rpath is a glob i.e contains a * or ? this check fails as it tries to query the path as is. That is the info on paths like "/root/a/*/b.txt" fails and raises an exception.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
    Will be done when merge to master
  • The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
  • Links to associated bugs, if any, are in the description.

@akharit akharit merged commit 4dad7a3 into dev Mar 1, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 86.556% when pulling 251d59c on akharit-fixGlobSingleFileBug into 750235b on dev.

@akharit akharit deleted the akharit-fixGlobSingleFileBug branch March 6, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants